Open
Conversation
… to test the stuff
API MuncherWhat We're Looking For
|
CheezItMan
reviewed
May 11, 2017
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
I made one note on your controller testing, if you need me to look at more or other tests, just ping me back and I'll take a look.
|
|
||
| describe "#create" do | ||
|
|
||
| it "can create a search" do |
There was a problem hiding this comment.
For this test case the proc is preventing errors from occurring, because `post login_path, params: {user: users(:aurora)} is raising an error because it's unable to find the user, but the proc is containing it. So the next 2 lines of the test never get executed.
You're also including search terms, health and user as params, but the controller is checking session for them (not sure why).
The test should look like
it "can create a search" do
post login_path, params: {
provider: users(:aurora).provider,
uid: users(:aurora).uid
}
must_respond_with :redirect
proc {
post save_search_path, params: {
search: {
search_terms: "pink lady",
health: "vegetarian",
user_id: users(:aurora).id}
}
}.must_change 'Search.count', 1
must_respond_with :success
endAnd I think from looking at it that the controller should be using params to save the search, not session. I'm not sure why session is involved at all.
…s a before action
added link to heroku app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions
PLEASE HELP ME WITH THESE QUESTIONS!
THANK YOU!!